Skip to content

Clean up update logic for java archives/debs #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loosebazooka merged 1 commit into from
Nov 6, 2025
Merged

Clean up update logic for java archives/debs #1923

loosebazooka merged 1 commit into from
Nov 6, 2025

Conversation

@loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Nov 6, 2025

  • auto manage versions in tests
  • apply current updates to adoptium deb and github releases

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 6, 2025

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining up-to-date Java dependencies by upgrading Java 21 to its latest patch version (21.0.9+10) for both direct GitHub releases (Temurin archives) and Adoptium Debian packages. A significant part of this change involves enhancing the internal knife utility to automate the propagation of these version updates into relevant test configurations, improving the efficiency and reliability of future Java version management.

Highlights

  • Java 21 Update: Updated Temurin Java 21 archives (JRE and JDK) to version 21.0.9+10 across all supported architectures (amd64, arm64, s390x, ppc64le) in MODULE.bazel.lock and private/repos/java_temurin/java_21.MODULE.bazel. This includes updating download URLs, SHA256 checksums, and version metadata.
  • Adoptium Debian Package Updates: Updated the trixie_adoptium.lock.json file to reflect the latest Temurin 21 (21.0.9.0.0+10) and Temurin 25 (25.0.1.0.0+8) Debian package versions for the ppc64el architecture, along with their corresponding SHA256 hashes.
  • Automated Test Version Management: Introduced a new knife.d/update_java_versions.sh script and integrated its functions into the knife utility. This script automates the process of updating expected Java versions in test data YAML files (java/testdata/java21_debian12.yaml, java/testdata/java21_debug_debian12.yaml) based on the versions locked in the Bazel module and Debian lock files, simplifying future version bumps.
  • Refactored Update Logic: The knife.d/update_java_archives.sh script was refactored to remove manual version tracking and streamline the generate_java_archives function. The cmd_update_java_archives command in knife now directly calls the new test version update function.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/update-deb-package-non-snapshots.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

🌳 🔧 Config Check

This pull request has not modified the root BUILD

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Java dependencies to newer versions and refactors the associated update scripts for better automation. The changes look good, but I have a few suggestions to improve the shell scripts for better maintainability and efficiency, and to restore some comments for readability in a Bazel module file.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

🌳 🔄 Image Check

This pull request has modified the following images:

//java:java21_root_s390x_debian12
//java:java21_root_ppc64le_debian12
//java:java21_root_arm64_debian12
//java:java21_root_ppc64le_debian13
//java:java21_nonroot_amd64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_debug_root_ppc64le_debian13
//java:java21_nonroot_s390x_debian12
//java:java21_debug_nonroot_ppc64le_debian13
//java:java21_debug_nonroot_arm64_debian12
//java:java21_nonroot_ppc64le_debian12
//java:java25_nonroot_ppc64le_debian13
//java:java21_debug_root_s390x_debian12
//java:java25_root_ppc64le_debian13
//java:java25_debug_nonroot_ppc64le_debian13
//java:java21_nonroot_ppc64le_debian13
//java:java25_debug_root_ppc64le_debian13
//java:java21_root_amd64_debian12
//java:java21_debug_nonroot_s390x_debian12

You can check the details in the report here

@loosebazooka
Clean up update logic for java archives/debs
669d12b 
- auto manage versions in tests
- apply current updates to adoptium deb and github releases

Signed-off-by: Appu Goundan <[email protected]>
@loosebazooka
Copy link
Member Author

loosebazooka commented Nov 6, 2025

okay these java updates are intentional -- jre/jdk versions are updated

@loosebazooka loosebazooka merged commit aa83e4e into main Nov 6, 2025
12 checks passed
@loosebazooka loosebazooka deleted the java_updater branch November 6, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobcallaway bobcallaway bobcallaway approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loosebazooka @bobcallaway